Entity validation should occur as the owner of the feed item, not the feed

If I'm not mistaken, Feeds does a second account switch (to the owner of the item) when you enable the "Authorize" option. I'm on mobile right now, so it's harder to check for me now if that is the exact option that triggered the second account switch, but at least there exists a second account switch in the code.

Hmm, the only place I see in the code where an account is switched is FeedsExecutable->processItem()

I quickly scanned the code of EntityProcessorBase in the web interface and cannot find that second account switch right now. But I was pretty sure that I had made that. Did I perhaps only implement that for the D7 version of Feeds? 🤔

Attaching patch for testing.

Adding updated patch with latest commit.

This is working for me.

I did find another instance of switchAccount(), in FeedQueueWorkerBase.php. I did not find when this code is called.

Saw that tests failed.

Regarding phpunit

If I’m reading this right, it failed at line #159 in FeedsExecutable.php, which is where I removed what I thought was an unnecessary if statement that checked if owner_id was set, as in my testing, I could not create a Feed type with this field empty, the default Anonymous user was always entered if I did not manually enter something. Presuming this is indeed the cause of the “Call to a member function getProcessor() on null” error. What am I missing here?

Regarding the next phpunit (next minor)

It looks like this also failed at line #159, so same issue.

Regarding the next phpunit (previous major)

It looks like this also failed at line #159, in addition to failing elsewhere.

Regarding the next phpunit (previous minor)

It looks like this also failed at line #159.

So it seems like adding back the if statement I removed would fix these things, but I would like some clarification as again, I could not create a Feed type with no value in the owner_id field. Want to make sure I’m looking in the right places…