- Issue created by @cbuvaneswaran
- 🇮🇳India cbuvaneswaran
Hi Team,
I created the issue fork and added the D11 support in info.yml. Please validate and merge the PR and then the release the D11 supported version of the module.
PR details: https://git.drupalcode.org/project/tealiumiq/-/merge_requests/22
Thanks and Regards,
Buvaneswaran - 🇺🇸United States jastraat
Getting the following error with Drupal 11 on /admin/config/services/tealiumiq/defaults:
ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/html/web/modules/contrib/tealiumiq/src/Form/Defaults.php on line 33 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 44 of core/lib/Drupal/Core/Form/ConfigFormBase.php). - 🇺🇸United States jastraat
Also the sub-module for tealiumiq needs the info file updated as well.
- 🇺🇸United States jastraat
Updated the MR to add more Drupal 11 compatibility. Given that Drupal 11 ConfigFormBase is not compatible with versions prior to 10.2 I reflected that in the info files.
Note that the current method for requiring the necessary dependent modules for the sub-module does not work but that pre-dates the need for Drupal 11 compatibility and could be handled in a separate issue.
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.
- 🇺🇸United States schiavone
Looks like we need to revisit this. In the contruct method the $typedConfigManager cannot be protected. See https://www.drupal.org/node/3404140 →
public function __construct( ConfigFactoryInterface $configFactory, protected TypedConfigManagerInterface $typedConfigManager, Tealiumiq $tealiumiq, )
-
schiavone →
committed b6c13117 on 8.x-1.x
Resolve #3541777 "Add d11 support"
-
schiavone →
committed b6c13117 on 8.x-1.x
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.