- Issue created by @berdir
- 🇨🇭Switzerland berdir Switzerland
I looked for others than those two examples, but these seem like the only quick wins. There are others that can be investigated, but for them, it's then services that they inject that we can possibly optimize, such as session manager (database), state (lock), cache tag invalidation (all cache bins that would get called on an invaidation), but I think that's out of scope. Probably better to do this piece by piece.
The result, see also attached files:
This is frontpage of standard profile, not logged in, with disabled page cache.
url_generator moved far down, it's only initialized as part of the is frontpage cache context for the breadcrumb. Wondering if we really need that there.
I didn't do BC because these are event subscribers.
I did check blackfire as well, but there is no meaningful difference as those things are still needed for this scenario
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States smustgrave
Can we update the summary with the 2 services that are being targeted. And maybe something similar to the META where the previous chain was
router_listener -> router -> router.no_access_checks -> url_generator -> renderer -> theme.manager -> theme.registry -> extension.list.moduleand is nowxyz - 🇨🇭Switzerland berdir Switzerland
the before/after is in comment #1, with a screenshot of the diff, because it's really only readable with a colored word diff.
I updated the title, but there isn't a whole lot more that can be put in the issue summary.
The one question where we need an answer if if/how we want to do BC for this case. Event subscribers are explicitly excluded by the BC policy, so maybe the answer for this one is, no BC necessary.