- Issue created by @Bruno2
- 🇫🇷France mably
We need a reproducible scenario from a fresh Drupal instance in order to help.
- 🇩🇪Germany Bruno2
Same here, is it a bot message? I rewrite the trash code of the file and it fixes the internal server error! I tested it with D10 (PHP 8.1 and 8.3), D11 (PHP 8.3).
The old file performs a loop between loading language -> loading domain infos -> loading language -> loading domain infos -> ...
- 🇫🇷France mably
Sorry to repeat myself, but, without a complete detailed reproducible scenario from a fresh Drupal instance, there is nothing I can do here.
- 🇩🇪Germany Bruno2
That's all I can offer you. The original script is severely impacting site performance. Due to an internal server error, it's taking hours to find the correct file! There were several other issues with the module, but this was the main one. A fresh install doesn't display the error, but it depends on many factors, such as domain records, site configuration, and other modules. Perhaps there's an issue with large content and paragraphs. I don't know.
I have another project that uses the domain module. If that needs updating, I can try to provide you with more information.
- 🇫🇷France mably
Could you provide a merge-request? That would facilitate the review.
- 🇩🇪Germany Bruno2
This looks like the same error: https://www.drupal.org/project/domain/issues/3538150 💬 502 Bad Gateway on Frontend After Update to beta 3 (from 2) Active
I hope this is correct, I don't work with Git that often.
Can you delete the DomainConfigOverrider.php_.txt? One of the two files is also crap; the evening was too long that day.
- 🇫🇷France mably
We need a merge-request so Gitlab CI can run the unit tests on it.
Seems like a pretty huge change.
We definitely need some explanations of what is being done there and why.
- 🇫🇷France mably
We are not magicians, sadly.
We are not getting paid to work on the Domain module either.
And we are only reviewing properly crafted merge-requests.