Typo on settings form

Created on 4 August 2025, about 2 months ago

Problem/Motivation

On SplideSettingsForm it says "Enable Splide library splide.min.css", but it should be .js

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ› Bug report
Status

Active

Version

2.0

Component

User interface

Created by

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom adamps

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @adamps
  • ๐Ÿ‡จ๐Ÿ‡ฆCanada danrod Ottawa
  • ๐Ÿ‡จ๐Ÿ‡ฆCanada danrod Ottawa

    I believe this doesn't need to be changed:

    modules/splide_ui/src/Form/SplideSettingsForm.php:

        $form['splide_css'] = [
          '#type'          => 'checkbox',
          '#title'         => $this->t('Enable Splide library splide.min.css'),
          '#description'   => $this->t('Uncheck to permanently disable the optional splide.min.css, normally included along with skins.'),
          '#default_value' => $config->get('splide_css'),
        ];
    

    ./src/SplideSkinManager.php:

      public function attachCore(array &$load, array $attach, $blazies = NULL): void {
        // @todo remove BC at 2.x with non-optional $blazies.
        $blazies = $blazies ?: $attach['blazies'] ?? NULL;
        if ($this->config('splide_css')) {
          $load['library'][] = 'splide/splide.css';
        }
    

    That checkbox is for enabling the default splide styling I think, the JS is loaded in the *.module.

    Correct me if I am wrong, but I think it's how it works.

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada danrod Ottawa
  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom adamps

    Thanks @danrod you are right.

    I see it now: libraries/splidejs--splide/dist/css/splide.min.css (that's the path on my system anyway). My mistake was that I was looking for the file within the module not the library. I acknowledge that the explanation did include the word "library" - I just didn't get the meaning๐Ÿ˜ƒ.

  • ๐Ÿ‡ฎ๐Ÿ‡ฉIndonesia gausarts

    Thank you all.

    Apart from the library, the optional word in the description might also be the hint to avoid confusion, so no correction is required.

Production build 0.71.5 2024