- Issue created by @boromino
- @boromino opened merge request.
- 🇩🇪Germany jurgenhaas Gottmadingen
This uses an interesting implementation pattern such that a token value is expected to be set and then being returned to the event afterwards. In other cases, we have introduced separate action plugins to set the return value back to the event. Doing it with the clean-up is clever and we may well change other implementations to use something similar.
What I'm wondering, though: do we have to make the token name configurable? We could instead hard-code the token name, which would then just be one less decision a user has to make.
Apart from that, I've left a few comments in the MR.
- 🇩🇪Germany jurgenhaas Gottmadingen
Only one code suggestion, I've added the changed code block to the comment in the MR.
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.
-
jurgenhaas →
committed 4870f057 on 3.0.x authored by
boromino →
[#3539583] feat: Add migrate process plugin By: boromino By: jurgenhaas
-
jurgenhaas →
committed 4870f057 on 3.0.x authored by
boromino →