There are currently 78 test classes extending GenericModuleTestBase. That means any unnecessary work is performed over and over again. One step we can remove is creating and logging in a user to load the help page for a module. Instead we can just grant anonymous users access to the help pages. For me that saves around 1.7 seconds per test, or 2m 13s overall.
time ./vendor/bin/phpunit -c core --filter=testModuleGenericIssues
Before:
real 6m58.566s
user 3m23.528s
sys 0m29.718s
After:
real 4m45.496s
user 3m4.862s
sys 0m29.171s
- $this->drupalLogin($this->createUser(['access help pages']));
+ user_role_grant_permissions(\Drupal\user\RoleInterface::ANONYMOUS_ID, ['access help pages']);
Active
11.0 🔥
system.module
Seems like a straight forward update and the benchmark you provided looks like a good net improvement.
I was surprised to see user_role_grant_permissions() but I see 📌 Deprecate user_role_grant_permissions() and user_role_revoke_permissions() Needs work is still going.
Committed/pushed to 11.x, thanks!