Invalid check in domain_config_ui_save_warning_message

Steps to reproduce

- Have multiple domains set up
- Enable domain configuration for some settings
- As a user without the 'set default domain configuration' permission, go to edit the config
- As they can't edit all, they don't see the 'All domains' option but you'll see "This configuration will be saved for all domains without custom configuration and displayed in all languages"
- Switch to another domain
- You'll see "This configuration will be saved for the domain and displayed in all languages."

The check is using `!is_null` but I think it should be `is_null`

// In some cases, the user cannot use 'all domains.' In that case, we have to // use the default option as a label. if (!is_null($selected_domain) && !\Drupal::currentUser()->hasPermission('set default domain configuration')) { ..

Comments & Activities

Issue created by @kimberleycgm
Merge request !159This message is valid when no domain is selected. Fix the is_null check. → (Merged) created by kimberleycgm
Pipeline finished with Success
22 days ago
#562552
Comment 22 days ago →
🇬🇧United Kingdom kimberleycgm
In fact I think there are more issues here. The form still loads as if for the 'all domains' version rather than the default domain.
Comment 17 days ago →
🇫🇷France mably
We need a complete detailed reproducible scenario from a fresh Drupal instance in order to help.
Comment 15 days ago →
🇫🇷France mably
@kimberleycgm I have finally been able to reproduce the bug.

And your MR fixes the warning message part, thanks.

But as you said, it's still the "All domains" values that appear in the form below by default until you select the domain in the list.
Comment 15 days ago →
🇫🇷France mably
Let's merge this as this for now.

Feel free to create a follow up issue for the "All domains" form values.
Comment 15 days ago →
🇫🇷France mably
In fact, it looks like the set default domain configuration permission hasn't been implemented at all, besides hiding the "All domains" entry in the switch list.
Comment 1 day ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Invalid check in domain_config_ui_save_warning_message

Drupal Version

Domain module version

Expected Behavior

Actual Behavior

Steps to reproduce

Merge Requests

!159Invalid check in domain_config_ui_save_warning_message
Merged

Comments & Activities

Invalid check in domain_config_ui_save_warning_message

Drupal Version

Domain module version

Expected Behavior

Actual Behavior

Steps to reproduce

Merge Requests

!159Invalid check in domain_config_ui_save_warning_messageMerged

Comments & Activities

!159Invalid check in domain_config_ui_save_warning_message
Merged