- Issue created by @benabaird
- πΊπΈUnited States benabaird
All test pass, marking as needs review!
- heddn Nicaragua
If we are going to work in this space, can we also adjust SnippetTest so it no longer try/catches MigrateSkipProcessException?
- πΊπΈUnited States benabaird
Thanks, updated that test, which looks to indirectly test the SkipOnValue change as well.
- heddn Nicaragua
I think we need to also bump the minimum drupal core version to 10.3 at this point too.
- πΊπΈUnited States benabaird
Oh probably, even if this was already implicitly done in Fix remaining code quality findings π Fix remaining code quality findings Active . If you want to do that in this issue I can bump it.
There's a few todos in code that should probably be cleaned up in a separate issue which I found after looking through the snippet plugin when implementing the test. Not sure if this is a complete list, I just searched the codebase for "10".