Remove the LogicException in ComponentTreeLoader that forces XB to only work with article nodes

Alternative approach: if we don't want to remove the exception outright, another option that will work for us is to remove this from ContentTemplateAwareViewBuilder:

      try {
        $this->componentTreeLoader->getXbFieldName($entity);
      }
      catch (\LogicException) {
        // This entity isn't opted into XB, so there's nothing else to do.
        continue;
      }

This would mean we don't care if any entity is "opted into" XB or not -- only that a template exists. However, we'd certainly want to restore this logic, or equivalent logic, at a later time.

The only difference that this MR brings is the exception logged in the database and is step forward and we would have to delete this sooner or later. I'm OK with this.

I've fixed one phpunit test and all should be green now.

need the ability to render any entity type through an existing content template

As of https://git.drupalcode.org/project/experience_builder/-/commit/843e7b0b1..., ContentTemplates are only allowed for node content entities, as proposed → by @effulgentsia as a realistically achievable goal for 1.0. @lauriii and I both +1'd this proposal, and made it so.

That did not implement all of ✨ [PP-1] Validate that content templates are attached to entity bundles that fulfill XB's requirements Postponed , but allowed us to make it no longer stable-blocking.

(Fun fact: you created #3518272, @phenaproxima! :D)

+1 to removing this exception.

But let's convert rather than delete existing test coverage to expect the fallback exception? i.e. this one:

throw new \LogicException("This entity does not have an XB field!");

I might be missing something obvious, but I don't understand why we wouldn't keep that.

Ah … I guess that is what #4 is implicitly referring to — I think removing that catch (and the other one in the same file) is the right thing to do.

Thanks — looks great now! 👍

Automatically closed - issue fixed for 2 weeks with no activity.