Fix deprecation notices on ProviderRepositoryDecorator

Problem/Motivation

The following warnings display on ProviderRepositoryDecorator

Deprecated: Optional parameter $key_value_factory declared before required parameter $module_handler is implicitly treated as a required parameter in /var/www/html/web/modules/contrib/oembed_providers/src/OEmbed/ProviderRepositoryDecorator.php on line 116

Deprecated: Optional parameter $logger_factory declared before required parameter $module_handler is implicitly treated as a required parameter in /var/www/html/web/modules/contrib/oembed_providers/src/OEmbed/ProviderRepositoryDecorator.php on line 116

Proposed resolution

Switch parameter order on constructor, also avoid constructing calling methods to avoid serialization issues, and we can also avoid calling the logger by leveraging https://www.drupal.org/node/3395436 →