- Issue created by @isholgueras
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
- Remove the srcSetCandidateTemplate occurrences.
👎
Please don't.
What matters is that it's been removed from
json-schema-definitions://experience_builder.module/image
in/schema.json
. That means all existing SDCs that use the XB-defined "image" prop shape won't getsrcSetCandidateTemplate
The only place where it occurs is in the
image-srcset-candidate-template-uri
test SDC, which was created intentionally, precisely to verify that matching against aDynamicPropSource
that has a{"type":"string","format":"uri-template","x-required-variables":["width"]}
shape still works.That was added in https://git.drupalcode.org/project/experience_builder/-/merge_requests/1....
See
'sdc.xb_test_sdc.image-srcset-candidate-template-uri' => [ // This test SDC does indeed not have a corresponding StaticPropSource, // because its purpose is to test the ability for components to opt in // to consuming additional computed properties on a field instance. // See the `the image-srcset-candidate-template-uri component` test case // in FieldForComponentSuggesterTest. // @see \Drupal\Tests\experience_builder\Kernel\FieldForComponentSuggesterTest 'Experience Builder does not know of a field type/widget to allow populating the <code>srcSetCandidateTemplate
prop, with the shape
{"type":"string","format":"uri-template","x-required-variables":["width"]}
.',
],
If you want, you can rename that prop in that test SDC, but I don't see why that's worth doing? 😅
- 🇪🇸Spain isholgueras
Oh, I see it now. Ok, make sense then. I thought it was leftover code.
No, it doesn't make sense to rename it. I think it can be closed.
Thanks!