- Issue created by @pdureau
- 🇫🇷France pdureau Paris
Remove entity_config_id?
According to Jean, we need a fallback for the demo instance.
- 🇫🇷France pdureau Paris
Less risky to do it after we have the test coverage.
- 🇫🇷France pdureau Paris
I will take the opportunity to remove this duplicate in tests/src/Kernel/DisplayBuilderTest.php:
#[CoversClass('\Drupal\display_builder\Entity\DisplayBuilder')] #[CoversClass('\Drupal\display_builder\Entity\DisplayBuilder')]
- 🇫🇷France pdureau Paris
In Profile entity & ProfileForm: from enable to enabled
Will be done in its own issue: 📌 Profile entity: From enable to status Active
- 🇫🇷France pdureau Paris
Instead of renaming
_instance_id
by_source_id
, we will rename it by_node_id
in order to- avoid ambiguity like that
setSource(string $source_id, string $source_id, array $data):
- fir with the expected vocabulary in data tree structure: https://en.wikipedia.org/wiki/Tree_(abstract_data_type)
- avoid ambiguity like that
- 🇫🇷France pdureau Paris
Ready for review. I have updated everything public facing: interfaces, storage (config, content, state...), constant, HTTP routes, HTML markup...
But, in order to keep the MR manageable and reviewable:
- i didn't update the names privately living inside methods.
- i let the ambiguous "builder" variable name, knowing the surrounding context (Interfaces, mostly) is now explicit about it
I have this eslint errror on files I haven't touched:
fatal: ambiguous argument 'tests/src/Playwright/__snapshots__/Tests/entity_view.spec.ts/entity-override.aria.yml': unknown revision or path not in the working tree.
- 🇫🇷France pdureau Paris
I rebase the branch 1.0.x and port the changes to the code added there.
- First commit to issue fork.
-
mogtofu33 →
committed 4a061ded on 1.0.x authored by
pdureau →
[#3538360] chore: Profile & Instance naming normalization
-
mogtofu33 →
committed 4a061ded on 1.0.x authored by
pdureau →
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.