Toolbar aural view tests pass falsely

Created on 23 July 2025, 12 days ago

Problem/Motivation

The aural view tests don't work for me.

I can change the announced messages in ToolbarAuralView.js, remove the announcements entirely, change the assertion to something that will definitely fail, or put bogus code in the callbacks, and the tests still pass.

It appears to be caused by a missing argument. The second argument of Nightwatch's .execute*() should be the arguments to be passed into the function that's specified in the first .execute*() argument.

Instead, the second argument is the callback.

Steps to reproduce

  1. In ToolbarAuralView.js, change one of the announced messages to something that certainly fail.
  2. Run the test.

The test will fail.

The test passes.

Proposed resolution

Add an empty array as the second argument to the .execute*() function.

πŸ“Œ Use ARIA disclosure pattern for Toolbar buttons with trays Active will remove the test for the tray toggle. In that case, only the Aural view test: tray orientation needs changing.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Active

Version

11.0 πŸ”₯

Component

toolbar.module

Created by

πŸ‡ΊπŸ‡ΈUnited States kentr Durango, CO

Live updates comments and jobs are added and updated live.
  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024