- Issue created by @chrisfromredfin
- Merge request !833Issue #3537468: Add gin theme specific style for module select button. → (Merged) created by Unnamed author
- 🇮🇳India anirudhsingh19
Improved the colors of the select button. When using the gin admin theme for both in light and dark mode.
- 🇮🇳India anirudhsingh19
@phenaproxima Thanks for the feedback. I'll look into it and try to accomplish it using classes. But, in the gin.css file there is already a huge amount of styling done using CSS IDs (#project-browser), I'm not sure why it has been used.
- 🇮🇳India anirudhsingh19
Used CSS classes instead of IDs, also resolved the stylelint errors which were leading to pipeline failure. Moving to Needs review.
- 🇮🇳India libbna New Delhi, India
I have reviewed MR !833. Earlier, the buttons appeared white, but after applying the changes from this MR, it now displays correctly in dark mode. I also checked in light mode, and the buttons look good there as well.
- 🇺🇸United States phenaproxima Massachusetts
Screenshots look good to me, no objections to the CSS (although I'm not really the one to make the determination about that).
-
chrisfromredfin →
committed c4b55be4 on 2.1.x authored by
anirudhsingh19 →
Issue #3537468 by anirudhsingh19, chrisfromredfin, libbna, phenaproxima...
-
chrisfromredfin →
committed c4b55be4 on 2.1.x authored by
anirudhsingh19 →
-
chrisfromredfin →
committed ca1ce11b on 2.0.x authored by
anirudhsingh19 →
Issue #3537468 by anirudhsingh19, chrisfromredfin, libbna, phenaproxima...
-
chrisfromredfin →
committed ca1ce11b on 2.0.x authored by
anirudhsingh19 →
- 🇺🇸United States chrisfromredfin Portland, Maine
Tested and works great. Thanks everyone! Merged to 2.1.x and cherry-picked clean to 2.0.x
Automatically closed - issue fixed for 2 weeks with no activity.