Strict return type of filter tips is in conflict with what is returned

Created on 18 July 2025, 3 months ago

Problem/Motivation

 Uncaught PHP Exception TypeError: "Drupal\ckeditor_taxonomy_glossary\Plugin\Filter\GlossaryLinkFilter::tips(): Return value must be of type string, Drupal\Core\StringTranslation\TranslatableMarkup returned" at /var/www/html/web/modules/contrib/ckeditor_taxonomy_glossary/src/Plugin/Filter/GlossaryLinkFilter.php line 171

Steps to reproduce

Proposed resolution

The Drupal base class and interface do require a strict return type. The PHPDoc is a bit clunky, because it says "string", although in a lot of examples it's returning t() and therefore a TranslatableMarkup object.

Right now the easiest is to remove the strict return type and call it the day.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇩🇪Germany szeidler Berlin

Live updates comments and jobs are added and updated live.

Merge Requests

!2Strict return type of filter tips is in conflict with what is returned
Merged
🇩🇪Germany szeidler
updated 3 months ago

Comments & Activities

Issue created by @szeidler
Merge request !2Issue #3536818 by szeidler: Strict return type of filter tips is in conflict with what is returned → (Merged) created by szeidler
Comment 3 months ago →
🇩🇪Germany szeidler Berlin
Here's a MR for it.
First commit to issue fork.
Pipeline finished with Skipped
3 months ago
#551168
Comment 3 months ago →
System Message

doxigo → committed bfe03bc9 on 1.0.x authored by szeidler →
Issue #3536818 by szeidler: Strict return type of filter tips is in...
Comment 3 months ago →
doxigo
Thanks again Stephan, merged
Comment 2 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024