- Issue created by @nicxvan
- π¦πΊAustralia mstrelan
Postponed on π Convert final 4 preprocess hooks in core modules Active .
- πΊπΈUnited States dcam
I don't know that there's much to say about this change. The hook is still invoked after applying the MR. Personally, I commented out the
comment_form
variable then rebuilt the cache and it stopped being rendered. The new comment is a good one to make sure no one tries to remove that condition later thinking that it's redundant. This looks good to me. - π¬π§United Kingdom catch
Yeah good to add the comment.
After committing I realised we have two issues open dealing with these collisions. We could have added a @todo, but seems silly to revert for that, so just adding as related issues.
Committed/pushed to 11.x, thanks!
- π¬π§United Kingdom catch
This might be the most comments trying to mark an issue fixed relative to the other comments on an issue.