- Issue created by @nicxvan
- 🇦🇺Australia mstrelan
Postponed on 📌 Convert final 4 preprocess hooks in core modules Active .
https://www.drupal.org/project/drupal/issues/3535943 📌 Convert final 4 preprocess hooks in core modules Active
It was uncovered that the preprocess field precursors have been completed.
@mstrelan
I know we're just moving things around, but I don't think we should ignore this. The todo issue has been "fixed" for 10 years. So can we change this to use #[Hook('preprocess_field__comment')] or does that not work yet or will that never work?
@mstrelan
In fact I tested it by making the suggested change, putting a breakpoint in the method and running \Drupal\Tests\comment\Functional\CommentNonNodeTest.
Potentially we can remove the if ($element['#field_type'] == 'comment') condition as well.
@berdir
One problem is #1367354: [PP-1] The list of theme hook suggestions for "field" is incorrectly ordered and has namespacing collisions → . This would also match all fields on a bundle named comment, as well as fields named comment, not just those of type comment
Active
11.0 🔥
comment.module
Postponed on 📌 Convert final 4 preprocess hooks in core modules Active .