Convert final 4 preprocess hooks in core modules

One comment on the @todo item for #939462: Specific preprocess functions for theme hook suggestions are not invoked → otherwise looks good.

One note: If we then indeed converted all module preprocess to OOP then that means we wouldn't have any test coverage of the BC layer for this.

On the plus side, that means we can formally deprecate legacy preprocess functions and as part of that, introduce one example in a test module to ensure that deprecations are triggered correctly, lets make sure we have an issue for that.

Yes I meant to add one to the legacy hook module. But technically there are themes implementing them still.

Created follow ups.

Confirmed all hooks still working:

• CommentThemeHooks::preprocessField invoked in \Drupal\Tests\comment\Functional\CommentNonNodeTest
• MediaLibraryThemeHooks::preprocessViewsViewMediaLibrary is invoked in MediaLibraryTestBase::assertMediaLibraryGrid
• ViewsThemeHooks::preprocessNode is invoked in \Drupal\Tests\views\Kernel\Entity\RowEntityRenderersTest::testEntityRenderers
• ViewsThemeHooks::preprocessComment is invoked in \Drupal\Tests\comment\Functional\CommentRssTest::testCommentRss

Agreed with the two follow-ups, but there is one outdated comment I think we should delete here. Would have done it in gitlab suggestions but it's not letting me delete those three lines in a suggestion.

Removed that comment block!

FYI if there is a comment on a line you can't do a multiline suggestion by dragging the comment icon.

You can either do two suggestions, one for the line with the comment and a single for the other lines.

Or you can click the suggestion then change the line numbers in the comment, but that gets tricky, I think desktop will update to show you what you are editing, but phone won't.

Either way I don't mind making the change myself, just sharing some gitlab tips I've discovered.

Also removed ProceduralHookScanStop here for media module as @berdir pointed out here: 📌 [pp-1] Mark several more modules as converted Active

Think this is back to NW for @berdir's latest comment about the ProceduralHookScanStop

Nope, I took care of that this morning, ready for review!

Oh in the mr! Sorry you're right!

I undid the media changes

Think this is good to go. Failing test is unrelated.

Committed/pushed to 11.x, thanks!

catch → closed merge request !12720