- Issue created by @balintbrews
- Merge request !1306#3536124: Configure Drupal API Client automatically for code components β (Merged) created by Unnamed author
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
balintbrews β credited wim leers β .
- π³π±Netherlands balintbrews Amsterdam, NL
Ready for a first-round review to see if we like the approach. I assume we'll want one or more additional tests in
tests/src/Functional/CodeComponentDataProviderTest.php
. - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
balintbrews β credited larowlan β .
- π³π±Netherlands balintbrews Amsterdam, NL
+1 by @larowlan, back to me for adding tests.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Posted additional feedback and made one slight adjustment to (IMHO) simplify things β this is looking great! π
-
balintbrews β
committed 93155a58 on 0.x
Issue #3536124 by balintbrews, wim leers, larowlan, mglaman: Configure...
-
balintbrews β
committed 93155a58 on 0.x
- π³π±Netherlands balintbrews Amsterdam, NL
The MR previously received +1s from @larowlan and @wim leers. I'll open a follow-up for an additional unit test. @mglaman helped me verify the changes with manual testing.
Failing end-to-end tests are not related. We have a few in 0.x right now that have been failing all day, so we'll need to address those.