phpcs detects
FILE: /var/www/html/web/modules/contrib/migrate_tools/src/MigrateTools.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
64 | WARNING | The $escape parameter must be passed when calling str_getcsv() as its default value will change in a future PHP version.
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/web/modules/contrib/migrate_tools/src/Drush/Commands/MigrateToolsCommands.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------
881 | WARNING | The $escape parameter must be passed when calling fputcsv() as its default value will change in a future PHP version.
883 | WARNING | The $escape parameter must be passed when calling fputcsv() as its default value will change in a future PHP version.
---------------------------------------------------------------------------------------------------------------------------------------Active
6.1
Code
I don't see these errors when running phpcs locally w/ php 8.4. How did you see these issues?
with the standard PHPCompatibility
http://phpcompatibility.com/PHPCompatibility/
./vendor/bin/phpcs -p web/modules/contrib/migrate_tools --standard=PHPCompatibility
Can we add a test for this? I don't see any failing tests showing this issue. BTW, I'm certain it is a problem, we just should add tests.