Deprecate $variables['page'] in taxonomy term templates

blocker is in

The views changes for the test point out there may be some BC issues here (assuming the same for the node change) but I suppose rendering either in views using the full view mode should be somewhat rare?

The node issue was deprecated for D13, we should probably do the same here.

The one deprecation message with removal D12 was accidental, have fixed that.

Checked all deprecations, looks good now. Added one suggestion to remove an extra space.

Committed/pushed to 11.x, thanks!

catch → closed merge request !13057

The change record should say what to use instead of the deprecated function template_preprocess_taxonomy_term.

We deprecated dozens of template_preprocess functions without specific change records/instructions, see all the issues in 📌 [pp-1] Convert Template Preprocess hooks to OOP equivalent Postponed: needs info .

I don't think we'd strictly need to provide BC for them at all, and you're not supposed to call it directly at all, it's a more a hook (of which we removed thousands without BC) than an API function. When I started in theme.inc with those deprecations, there were a handful that were extending from each other, so I started to add BC and we kept up with that pattern. But that's mostly for generic things like table (where field_ui has a special kind of table and called template_preprocess_table() from it's own template_preprocess.

Yes agreed with @berdir here - there is a theoretical possibility that someone calls preprocess hooks directly so we add best effort bc just in case, but they're considered @internal and no-one should call them, so we shouldn't tell people how to do that in a 'new' way.