- Issue created by @luenemann
- Merge request !32Resolve #3534875 "Error when deleting" make idList optional (quick fix) → (Merged) created by luenemann
- 🇩🇪Germany luenemann Südbaden, Germany
Just created a MR !32 with the quick fix. Tested locally.
I am in favour of the proper fix. Wiche solution is preferred? - 🇨🇦Canada _randy
Thanks for the patch. idlist is used, so making it optional for this edge case is fine.
-
_randy →
committed adc1ebfd on 4.x authored by
luenemann →
Resolve #3534875 "Error when deleting" make idList optional (quick fix)
-
_randy →
committed adc1ebfd on 4.x authored by
luenemann →
- 🇩🇪Germany luenemann Südbaden, Germany
Hi _randy,
I've made the change to the route "maestro.delete.task", that was wrong 🤦♂️. The correct route is "maestro.delete.process".
I propose to revert the wrong change, because idList in "maestro.delete.task" is required.From what I can see the parameter "idList" in "maestro.delete.process" is unused.
I am in favor to remove it. - Merge request !33Resolve #3534875 "Remove idList form route maestro.delete.process" → (Merged) created by luenemann
- 🇩🇪Germany luenemann Südbaden, Germany
Please review MR !33 wich removes the parameter idList in route maestro.delete.process.
- 🇨🇦Canada _randy
Update this MR to include the undoing of the already committed idlist parameter optional flag then?
- 🇩🇪Germany luenemann Südbaden, Germany
luenemann → changed the visibility of the branch 3534875-error-when-deleting to hidden.
- 🇩🇪Germany luenemann Südbaden, Germany
Just added a revert commit to the MR !33.
I changed the MR to not squash the commits, so that there is a separate commit for the revert.
-
luenemann →
committed a41d00bd on 4.x
Issue #3534875 by luenemann: Error when deleting a MaestroProcess...
-
luenemann →
committed a41d00bd on 4.x
-
luenemann →
committed cdab8289 on 4.x
Revert "Resolve #3534875 "Error when deleting" make idList optional (...
-
luenemann →
committed cdab8289 on 4.x