- Issue created by @lrwebks
- 🇩🇪Germany Anybody Porta Westfalica
We should also add an explicit permission to enter / edit the JS for security reasons.
- 🇩🇪Germany lrwebks Porta Westfalica
As discussed with @anybody, I have moved all code related to the JS ad type into a separate submodule, and we will tackle the proposed solution there.
- 🇩🇪Germany Anybody Porta Westfalica
Merging current state so that we can then finish this in a follow-up branch.
-
anybody →
committed 53e06453 on 11.x authored by
lrwebks →
Issue #3534872 by lrwebks, anybody: JS advertisement type does not yet...
-
anybody →
committed 53e06453 on 11.x authored by
lrwebks →
- 🇩🇪Germany Anybody Porta Westfalica
@grevil: Since moving the configs over into the sub-submodule, the tests are broken - they worked before. Any idea? Maybe a config dependency we overlooked?
- 🇩🇪Germany lrwebks Porta Westfalica
Everything is done now, apart from finding the reason of the test failure. But as far as I understand, @grevil will take a look at that? So I'll set this to review now.
- 🇩🇪Germany lrwebks Porta Westfalica
I'll quickly add a conditional message if the user is lacking the permission to edit the JS field.
- 🇩🇪Germany lrwebks Porta Westfalica
It currently appears to be near impossible to change the field description in the alter hook, as every attempt I have pursued at changing it seemed to have no effect. I have committed my best attempt at this time, which successfully updates the description in code, but does appear to cause any change in the displayed text.
@grevil, perhaps you know a proper solution to this?