- Issue created by @emircan erkul
- 🇩🇪Germany jurgenhaas Gottmadingen
There isn't anything to review here, and the issue is assigned, so that usually means, nobody else is likely looking at it.
I guess it would help if you could provide more details, especially why this should be a Gin issue and not a gutenberg issue.
- Merge request !633Issue #3417719: Refine User Experience: Addressing Size, Position, and Hover... → (Open) created by emircan erkul
- 🇩🇪Germany jurgenhaas Gottmadingen
That MR!633 needs to go into gutenberg, not into Gin.
- 🇹🇷Turkey emircan erkul Turkey
Wow @jurgenhaas, you were quick :) I was working on it thats why i put into review. It was quick fix. Of course it is debatable where to put this styling. Yes best one would be in gutenberg module checking if active admin theme is gin and injecting spesific styles (or vice versa we could check if gutenberg active then injecting based on that to save 2 line of css ) but yea quickest way is like this.
- 🇹🇷Turkey emircan erkul Turkey
@jurgenhaas feel free to review/modarate (close, discard etc.) or anyone could open this into gutenberg module.
But they might also say this is not gutenberg module issue and should be created in gin, right? But idk maybe we could create new module to do not cause World War 3 :)
- 🇩🇪Germany jurgenhaas Gottmadingen
Well. Gin is styling those buttons and they work everywhere. And obviously Gutenberg brings something along, where they don't any longer.
In the past, Gin has incorporated many "quick-fixes" for contrib modules, but we will no longer do that. In fact, all of those will be removed from Gin and module maintainers will have to make sure, that their modules don't break the admin theme. We will open issues with each of those modules soon to let them know what needs to be done, and when Gin moves into core by the end of this year, all those adjustments will not come with it.