We've been dealing with exception issues in Custom Breadcrumbs, specifically in cases where it's being used to generate token strings for metatags. Due to the fact that it might not necessarily involve a valid route match from the current entity's canonical route, this means the TitleResolver might not be able to resolve the arguments for methods like `NodeViewController::title`, resulting in a RuntimeException being thrown.
This is probably a very roundabout way of hitting this problem, but we routinely use breadcrumb data in Metatags, whether it be to render out the breadcrumb for metatags or determine the main section of the site that a given page is in. If it's throwing exceptions in JSON:API that means there's a whole class of Drupal core functionality unavailable to us.
I've discussed this with @larowlan and we think that broadening the exception handling around the TitleResolver that was introduced in #318464 → might handle these cases. I can understand any reticence to expand this type check, but returning a NULL for the appended title is probably more useful than passing an exception further up the call stack.
This is a very simplified version of the flow of events that we think might reproduce this:
Broaden the exception handling around TitleResolver to catch \Throwable instead of \InvalidArgumentException.
None.
None.
None.
Active
1.0
Code
We've started running this patch in PRODUCTION and it has alleviated the issue described in the description above.
Automatically closed - issue fixed for 2 weeks with no activity.