- Issue created by @catch
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I see β thanks! @larowlan experimented with this just in the past 24 hours btw, in
See:
- https://git.drupalcode.org/project/experience_builder/-/merge_requests/4...
- https://git.drupalcode.org/project/experience_builder/-/merge_requests/4... (last hunk)
- https://git.drupalcode.org/project/experience_builder/-/merge_requests/4...
That last one changes us from 16 to (the then-default) of 32.
I think for XB, the concurrency of 32 might be preferable?
- π¬π§United Kingdom catch
32 is almost always going to be too many because you run into CPU contention.
https://git.drupalcode.org/issue/experience_builder-3534201/-/jobs/5779890 took 3m23s for the actual tests with 12 concurrency but there might be a bit more to do here too.
- π¬π§United Kingdom catch
Getting there - 2m49s https://git.drupalcode.org/issue/experience_builder-3534201/-/jobs/5781471
- π¬π§United Kingdom catch
- π¬π§United Kingdom catch
Tried 8 concurrency and that's much too low.
https://git.drupalcode.org/issue/experience_builder-3534201/-/jobs/5781754 came in at 3m40s, so seems to be between 2m30 and 3m40 which seems pretty good and likely the variation is which runner it ends up on.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Are you suggesting to stop using
#slow
? π€Lee tweaked it less than a day ago π
- π¬π§United Kingdom catch
The test ordering in 11.2 is much better by default because it's based on the number of test methods that will run using phpunit's own discovery. So you generally only have to add it to tests that are disproportionally slow. Doesn't remove the need for it, it's just needed less.
With lower test concurrency, a lot of the tests are running much faster - 32 concurrency with 2 CPUs is too much at once and drags everything down.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
I think anything that uses XbTestSetup should be marked slow until we fix π Decouple kernel tests from XbTestSetup Active , but not having to curate it so much would be great