- Issue created by @catch
- 🇬🇧United Kingdom catch
Put a rough MR up. Haven't looked at adding test coverage in DTT for this yet, but given the tests are tests using the base class it should be straightforward to add one. Would be good to know there aren't major showstoppers otherwise though.
- 🇺🇸United States moshe weitzman Boston, MA
No objection here. Looks nice and small.
I'm unsure if the phpunit fails are due to this PR or not. It was working two months ago - https://git.drupalcode.org/project/dtt/-/pipelines
- 🇬🇧United Kingdom catch
I cleaned up various mess in the MR, but phpunit tests are still failing and that's definitely not related to the changes here - see for example https://git.drupalcode.org/issue/dtt-3533690/-/jobs/5754008
Something wrong with the selenium driver image maybe?
- 🇺🇸United States moshe weitzman Boston, MA
I pushed a few changes. The module_installer in setUp() is get the error
Error: Call to undefined method Drupal\Core\ProxyClass\Extension\ModuleInstaller::moduleExists(). So thats commented out for now. The new test passes on my machine. Please confirm that Chrome is doing what its supposed to do.Still not sure whats up with Selenium Chrome.
- 🇬🇧United Kingdom catch
s. The module_installer in setUp() is get the error Error: Call to undefined method Drupal\Core\ProxyClass\Extension\ModuleInstaller::moduleExists(). So thats commented out for now.
Just needed to be module_handler instead of module_installer - pushed a commit for that.
Chrome is working when I run tests on a client project (that client project fails to send all the info to opentelemetry, but it's because too much information is collected in the test).
I should be able to test the full opentelemetry stack in a couple of weeks hopefully, but worst case it would be a small follow-up, the main thing here is getting the phpunit tests working.
