Do not fetch default image toolkit ID in ImageFactory::__construct()

Created on 1 July 2025, 3 days ago

Fetching the default toolkit means loading config, we shouldn't do that in a constructor.

With DI, the ImageFactory is injected into hooks, plugins and preprocess stuff even though it might not actually be required in a given scenario.

📌 Task

Status

Active

Version

11.0 🔥

Component

image system

Created by

🇨🇭Switzerland berdir Switzerland

Live updates comments and jobs are added and updated live.

Performance
It affects performance. It is often combined with the Needs profiling tag.

Merge Requests

Issue created by @berdir
Merge request !12563lazy initialize of toolkitId → (Open) created by berdir
Comment 3 days ago →
🇨🇭Switzerland berdir Switzerland
The problem is that this breaks BC for subclasses, of which there about 3 and I think at least the brandfolder one would be broken: http://codcontrib.hank.vps-private.net/search?text=extends%20ImageFactor...
Pipeline finished with Failed
3 days ago
Total: 491s
#535841
Comment about 5 hours ago →
🇺🇸United States smustgrave
Seemed to break some performance tests.

Anyway to cover with a deprecation. Like if Core version is 11.3 or great trigger a deprecation that toolkitId won't be set?

Production build 0.71.5 2024