Ensure base test classes don't have phpunit annotations

Created on 30 June 2025, 14 days ago

Problem/Motivation

Follow-up from 🐛 Fix test classes with no *Test suffix Active - we found various base classes in core that had phpunit annotations that won't do anything, we should check if there are more.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component

phpunit

Created by

🇬🇧United Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @catch
  • 🇮🇹Italy mondrake 🇮🇹

    I suggest to wait for conversions of annotations to attributes to be completed, then check on attributes instead. Probably a PHPStan rule should be written here.

  • Merge request !12705Closes #3533282 → (Open) created by mondrake
  • Pipeline finished with Failed
    2 days ago
    Total: 153s
    #546012
  • 🇮🇹Italy mondrake 🇮🇹

    Changed mind and added a PHPStan rule checking for either annotations or attributes on abstract test base classes. We have 17. errors to be solved.

  • 🇮🇹Italy mondrake 🇮🇹
  • Pipeline finished with Failed
    1 day ago
    Total: 245s
    #546195
  • Pipeline finished with Failed
    1 day ago
    Total: 153s
    #546207
  • Pipeline finished with Success
    1 day ago
    Total: 690s
    #546210
Production build 0.71.5 2024