- Issue created by @acbramley
- 🇺🇸United States nicxvan
Fun fact! I first found the oddity that is node mass update here 📌 [ignore] Convert everything everywhere all at once Active which is why I knew it wasn't a hook in the first place even though it goes through through module handler invoke.
There are not many of these types of calls left in core.
- 🇦🇺Australia acbramley
This is barely used in contrib, it would be nice if we could overhaul this with something more modern but maybe that could be done in follow-ups http://codcontrib.hank.vps-private.net/search?text=node_mass_update%28%2...
Speaking internally, @larowlan suggested changing the $updates array to a static closure that takes the loaded $node and would allow us to just call API directly. I think this would be a huge improvement and would be good for a follow up.
- 🇦🇺Australia acbramley
We chatted about naming internally and landed on
NodeBulkUpdate::process, the word "mass" doesn't really get used a lot in Drupal so this seemed to fit better.Setting to NR to get some eyes on it, agree on the naming, then I'll fix up the CR and make any further changes.
All tests for this are in core/modules/user/tests/src/Functional/UserCancelTest.php
