PerformanceTestTrait script/stylesheet size counting needs to handle external URLs

Open on Drupal.org →

Created on 27 June 2025, about 1 month ago

Problem/Motivation

I'm writing a performance test for an actual website code base - so far the only tests I know of are for core, Drupal CMS, and a contrib module.

This site has some modules installed that use CDN versions of stylesheets/scripts for third party integrations, and while they should be counted towards page weight, they shouldn't cause performance tests to explode.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Active

Version

11.0 🔥

Component

phpunit

Created by

🇬🇧United Kingdom catch

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!12518PerformanceTestTrait script/stylesheet size counting needs to handle external URLs
Closed
🇬🇧United Kingdom catch
updated 15 days ago

Comments & Activities

Issue created by @catch
Merge request !12518Handle external URLs correctly. → (Closed) created by catch
Pipeline finished with Running
about 1 month ago
#532945
Comment about 1 month ago →
🇬🇧United Kingdom catch
Comment about 1 month ago →
heddn Nicaragua
LGTM

Comment 15 days ago →

longwave → committed 57f7daa9 on 11.x

Issue #3532724 by catch: PerformanceTestTrait script/stylesheet size...

Comment 15 days ago →
System Message
longwave → closed merge request !12518
Comment 15 days ago →
🇬🇧United Kingdom longwave UK
I can think of slightly neater ways of writing this code but as this is an edge case mostly only used by @catch then let's just ship it and move on :)

Committed 57f7daa and pushed to 11.x. Thanks!
Comment 1 day ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024