- Issue created by @larowlan
- Merge request !1196Issue #3532495: Simplify ApiAutoSaveController::post β (Merged) created by larowlan
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
Glad I didn't add elseif in the suggestion, nice branch name π€£
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Makes sense, better to be safe than sorry - thanks
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
There's a bit I don't understand yet π
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
I don't feel that strongly, though, but a) there's no UI for creating regions; b) those are created when they are enabled for the theme in its settings, so feels safer to ensure they can't be created.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
It's not that I feel strongly, it's that I don't understand why
PageRegion
is special-cased compared to all others. Because β¦ all auto-saves are for updates to content & config entities only? IOW: it's impossible to create.Looks like the
enforceIsNew(FALSE)
was introduced in π Implement auto-save of the page template config entity Active . Will figure out which commit and why.P.S.: only now see the branch name π€£π€£π€£π€£π€£π€£π€£π
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Commit found: by @larowlan: https://git.drupalcode.org/project/experience_builder/-/merge_requests/4...
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Tried to generalize: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
That worked :)
@penyaskito: Do you agree with the tweak I made? If so: go ahead and merge! If not: what am I missing? π
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
Ship it!
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
I can't merge π
-
wim leers β
committed ece505b7 on 0.x authored by
larowlan β
Issue #3532495 by penyaskito, larowlan, wim leers: Simplify...
-
wim leers β
committed ece505b7 on 0.x authored by
larowlan β
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
@penyaskito and I paired to debug why he can't merge. Even after granting him all the d.o permissions and loosening GitLab settings, he still can't merge, whereas he really should be able to. Either GitLab is broken or d.o's integration with it π¬
Merged for him! π
Automatically closed - issue fixed for 2 weeks with no activity.