\Drupal\rest\Plugin\views\display\RestExport assumes view->getRequest() returns non-null; leads to fatal error during requestless executions like drush

Open on Drupal.org →

Created on 25 June 2025, 2 days ago

Problem/Motivation

\Drupal\rest\Plugin\views\display\RestExport::initDisplay may be invoked during route rebuilding via cache clear. If this method is invoked without a request, via drush for example, this can cause a fatal error.

Call to a member function getRequestFormat() on null in Drupal\rest\Plugin\views\display\RestExport->initDisplay()

Steps to reproduce

* Create a rest export view with a path
* Rebuild cache via drush

Proposed resolution

* Do not assume the request exists

Remaining tasks

* Update initDisplay method to check for request existence before invoking methods on it.
* Update \Drupal\views\ViewExecutable::getRequest docblock @return statement to include null as a possible return value.
* Does the property \Drupal\views\ViewExecutable::$request need to be updated to explicitly allow null?

User interface changes

none

Introduced terminology

none

API changes

none

Data model changes

none

Release notes snippet

🐛 Bug report

Status

Active

Version

11.2 🔥

Component

views.module

Created by

🇺🇸United States AaronBauman Philadelphia

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!12491\Drupal\rest\Plugin\views\display\RestExport assumes view->getRequest() returns non-null; leads to fatal error during requestless executions like drush
Open
🇺🇸United States AaronBauman
updated 2 days ago
!12490\Drupal\rest\Plugin\views\display\RestExport assumes view->getRequest() returns non-null; leads to fatal error during requestless executions like drush
Open
🇺🇸United States AaronBauman
updated 2 days ago

Comments & Activities

Issue created by @AaronBauman
Merge request !12490Test initializing a rest export display when view request is null → (Open) created by AaronBauman
Pipeline finished with Failed
2 days ago
Total: 322s
#531541
Merge request !12491Issue #3532439 - check for existence of request before invoking methods on it → (Open) created by AaronBauman
Pipeline finished with Failed
2 days ago
Total: 1257s
#531548
Pipeline finished with Failed
2 days ago
Total: 3390s
#531574
Pipeline finished with Failed
2 days ago
Total: 5474s
#531556
Comment 1 day ago →
🇳🇿New Zealand quietone
In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → . Also mentioned on the version → section of the list of issue fields documentation.
Comment 1 day ago →
🇺🇸United States AaronBauman Philadelphia
aaronbauman → changed the visibility of the branch 3532439-TEST-ONLY to hidden.
Comment 1 day ago →
🇺🇸United States AaronBauman Philadelphia
Depends on 🐛 Check for session before calling getSession(), or catch SessionNotFoundException Active

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024