Deprecate node_get_type_label()

Missing the @trigger_error()?

woops!

The change looks good.

I'm unsure about the D12 deprecation, while it's trivial and not used a lot, the suggested replacement requires 11.3. I'd suggest we expand the change record, mention that getBundleEntity is 11.3+ and suggest using $node->get('type')->entity->label() as an alternative which is fully backwards compatible and then we'll see if core maintainers are OK with that.

the suggested replacement requires

But the deprecation is also in 11.3, but I see where you're coming from for modules supporting both 11.3 and 11.2.

I've updated the CR.

CR reads fine and a good deprecation. Not sure what else to review..

I checked contrib and found 10-20 modules using this (three pages on gitlab search).

📌 Defer disruptive 11.3 deprecations for removal until 13.0 Active probably means this should be deprecated for removal in 13.0 - it's borderline given there's an 11.2 way to do this, but if we defer the deprecation to 13.x then modules that want to support 11.2 and 12.0.0 betas at the same time can ignore the change and do it once (to the new, new way) when they drop 11.2 support instead of twice.

Updated deprecation messages, back to RTBC since this is a trivial change.

Committed/pushed to 11.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.