- Issue created by @phenaproxima
- πΊπΈUnited States tim.plunkett Philadelphia
Nice work! Verified that the `initial preprocess` approach is the standard practice
- First commit to issue fork.
-
chrisfromredfin β
committed 136e6a89 on 2.1.x authored by
phenaproxima β
Issue #3531370: Convert hooks to OO
-
chrisfromredfin β
committed 136e6a89 on 2.1.x authored by
phenaproxima β
- πΊπΈUnited States chrisfromredfin Portland, Maine
11.2-only feature so no backport needed.
- πΊπΈUnited States nicxvan
Pretty sure the template preprocess needs only one `:` for the method, that's how @berdir has been doing it in conversions for core.
https://git.drupalcode.org/project/drupal/-/merge_requests/11807/diffs#f...
I had asked about it and since it's not a service a single is the way to do it.
Further, it doesn't hurt, but the empty post update hooks shouldn't be necessary either.
- πΊπΈUnited States tim.plunkett Philadelphia
That's actually backwards, the two syntaxes are
service:method
andclass::method
. However, the code in CallableResolver has identical code paths after exploding on either amount of :, it processes them the same by passing onto ClassResolver::getInstanceFromDefinition()Either way, it will work.
Automatically closed - issue fixed for 2 weeks with no activity.