Experience Builder mis-decorates the SDC plugin manager

Dead simple fix with a well-targeted test.

Discovered that this bug also exists for the block plugin manager. Let's fix that too.

Per @larowlan, restored missing dependencies to kernel tests which were (mistakenly) passing without them, obscured by this decoration bug.

wim leers → made their first commit to this issue’s fork.

wim leers → credited larowlan → .

🤯 How is this not a core bug?! Tagging for that, but … obviously not waiting for that to get fixed.

Not marking to get a core bug report filed 🙏

Why would this be a core bug?

XB is the thing that is decorating these plugin managers, and it targets them incorrectly. AFAICT, core isn't doing anything wrong here, apart from having more than one way to refer to these services, with the "canonical" way being the old names.

It's a core bug because if everywhere you can refer to services by their FQCN (including in *.services.yml when injecting services) except when decorating, then that's a DX WTF.

I'd then at minimum expect an example/test in core/modules/system/tests/modules/autowire_test/autowire_test.services.yml that shows that this does NOT work for decorators, and explains why.

But really, big WTF is that this has worked fine for all this time, until this issue: when used in Recipes, it suddenly breaks!?! 🤯

Test coverage like 🐛 Service decorates non-existant service when module not installed Needs work 's seems warranted.

P.S.: Seems like #3049525-5: Enable service autowiring by adding interface aliases to core service definitions → and some subsequent comments are also talking about this. But not much discussion about it :/