- Issue created by @mkalkbrenner
- Merge request !7Issue #3530298 by mkalkbrenner: Too few arguments to function... → (Merged) created by mkalkbrenner
- 🇫🇷France lazzyvn paris
check on drupal 10 and 11 class Serializer the construction doesn't need $module_handler
I have also the same issue. The bug occurs after an update of the drupal/views_data_export:1.5.0 to drupal/views_data_export:1.6.0. The views_data_export:1.6.0 was released on 13 June 2025. I revert the update with composer and the bug go away. If the D10 & D11 don't need $module_handler, maybe it will be better to fix the issue in views_data_export and not in views_data_export_phpspreadsheet, no ?
- First commit to issue fork.
- 🇯🇵Japan liuyuanchao
Maybe it's better to change like branch 3530298-too-few-arguments-2.
Please review. - 🇩🇪Germany mkalkbrenner 🇩🇪
I don't understand what are you discussing here. The base class you derived your plugin from changed its constructor with the latest release. You MUST adjust the constructor accordingly!
- 🇩🇪Germany mkalkbrenner 🇩🇪
OK, the parent didn't change the constructor, it added a constructor:
https://git.drupalcode.org/project/views_data_export/-/commit/dabf06138c... - 🇩🇪Germany mkalkbrenner 🇩🇪
Maybe it's better to change like branch 3530298-too-few-arguments-2.
Please review.I think that right pattern in drupal is to set values of member variables in the constructor, not in the create method.
-
lazzyvn →
committed 4ca9acb4 on 2.x authored by
mkalkbrenner →
Issue #3530298 by mkalkbrenner: Too few arguments to function...
-
lazzyvn →
committed 4ca9acb4 on 2.x authored by
mkalkbrenner →
- 🇯🇵Japan liuyuanchao
Error occurs when someone use the old version of views_data_export.
Should we add a restriction in composer.json? - 🇩🇪Germany mkalkbrenner 🇩🇪
yes, a version constraint should be added to composer.json and info.yml
- 🇯🇵Japan liuyuanchao
liuyuanchao → changed the visibility of the branch 3530298-too-few-arguments-2 to hidden.
- 🇯🇵Japan liuyuanchao
Hi @lazzyvn
I add the version constraint in 3530298-too-few-arguments branch.
Please review.https://git.drupalcode.org/issue/views_data_export_phpspreadsheet-353029...