- Issue created by @lussoluca
- Merge request !12354Issue #3529592 by lussoluca: Wrong alias for access_policy_processor service in core.services.yml → (Closed) created by lussoluca
- 🇨🇭Switzerland znerol
This has its origins in 🌱 [Meta, Plan] Pitch-Burgh: Policy based access in core Active . I guess the interface has been renamed during the development process. But @core.services.yml@ has been forgotten.
% git grep AccessPolicyChainInterface core/core.services.yml: Drupal\Core\Session\AccessPolicyChainInterface: '@access_policy_processor'
% git grep AccessPolicyProcessorInterface core/lib/Drupal/Core/Session/AccessPolicyProcessor.php:class AccessPolicyProcessor implements AccessPolicyProcessorInterface { core/lib/Drupal/Core/Session/AccessPolicyProcessorInterface.php:interface AccessPolicyProcessorInterface { [...]
Nightwatch test fails are random ones 🌱 [meta] Known intermittent, random, and environment-specific test failures Active .
- 🇮🇹Italy lussoluca Italy
I think this should also be backported to D10. Should I open a new issue or a new merge request?
- 🇨🇭Switzerland znerol
Bug fixes are cherry-picked by committers to active branches, see the core Backport Policy → .
- 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
This is indeed an oversight when converting from Flexible Permissions. Fix is straightforward, but tests seem to be failing on Nightwatch, please rerun those. And this should indeed be backported to D10.
Thanks for finding this!
- 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
Big RTBC+1.
To go into a little more detail: At first the processor was designed as a chain processor, which itself could be put into a chain. This design was copied from similar service collectors, but abandoned during the review process of getting Flexible Permissions into core as the Access Policy API.
The service alias must have gotten through the cracks of code review and it surprises me it took this long for someone to find it :) Once again, good catch. This should be easy to commit.
- 🇮🇹Italy lussoluca Italy
This is probably because services autowiring is not yet a common pattern among Drupal developers :-)