Set memory limit to -1 for phpstan precommit hooks

Defaulting to -1 is probably bad for CI, but an option would be nice.

Retitling to make it clear we are not, in fact, trying to take down GitLab.

Seems like a good improvement for developers.

I think we should remove the output as it is not telling you much and I'm not sure that it is helpful.

If this helps a committer commit then +1 - I think the maintenance burden is light and if PHPStan stops supporting the option it'll tell us with an easy error to fix. Also happy to merge https://github.com/alexpott/d8githooks/pull/34/commits/6c03a0ceae34850a9... once this lands.

Do you mean the print statements?

I had thought it would be helpful to clarify that memory limit is set since i assume most core committers use your precommit hooks and might not see the issue.

I'm happy to remove it too, just clarifying.

Yep the print statements - I'm not sure they add anything.

Thanks @alexpott! (@alexpott is the subsystem maintainer for this code.)

Done! Thanks

looks good to me... will merge once this rtbc.

I had thought it would be helpful to clarify that memory limit is set since i assume most core committers use your precommit hooks and might not see the issue.

We are a small group and whoever commits the followup to the git hooks will probably just tell the team. :)

I'll try to manually test this together with the PR later.

Feedback from @alexpott appears to be addressed.

Sorry, it was NR for manual testing with the upstream PR. I should have been explicit. I can do this, but am also fine for someone else to if they beat me to it.

Tested manually.

Without fix

1. Locally setting memory_limit = 256M
2. Reverting 🐛 PHPStan baseline is out of sync Active .
3. Applying patch from that issue.
4. Attempt to commit it (including running pre-commit checks).

Result:

Running PHPStan on *all* files.
PHP Fatal error:  Allowed memory size of 268435456 bytes exhausted (tried to allocate 181264717 bytes) in phar:///Users/xjm/git/maintainer/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/ResultCache/ResultCacheManager.php on line 172
Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 181264717 bytes) in phar:///Users/xjm/git/maintainer/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/ResultCache/ResultCacheManager.php on line 172

PHPStan process crashed because it reached configured PHP memory limit: 256M
Increase your memory limit in php.ini or run PHPStan with --memory-limit CLI option.

PHPStan: failed

With fix

1. Locally setting memory_limit = 256M
2. Reverting 🐛 PHPStan baseline is out of sync Active .
3. Committing the MR from this issue.
4. Fetching the latest changes in the d8githooks
5. Manually patching precommit in the d8githooks with the flag from that MR and committing the result.
6. Recommitting the patch from the baseline update (with precommit checks).

Result: Baseline update committed with full PHPStan scan.

Now it is RTBC. :)

Committed and pushed 2ffd3412fe7 to 11.x and 4842c65b535 to 11.2.x and ca127551d4f to 10.6.x and 642eb99e04e to 10.5.x. Thanks!

Backported to 10.5.x as this is non-runtime code and it does not hurt to have everything in sync.

xjm → closed merge request !12351

Automatically closed - issue fixed for 2 weeks with no activity.