- Issue created by @nicxvan
- πΊπΈUnited States xjm
Defaulting to -1 is probably bad for CI, but an option would be nice.
- Merge request !12351Pass in memory limit -1 if --memory-unlimited is set β (Open) created by nicxvan
- πΊπΈUnited States xjm
Retitling to make it clear we are not, in fact, trying to take down GitLab.
- πΊπΈUnited States smustgrave
Seems like a good improvement for developers.
- π¬π§United Kingdom alexpott πͺπΊπ
I think we should remove the output as it is not telling you much and I'm not sure that it is helpful.
- π¬π§United Kingdom alexpott πͺπΊπ
If this helps a committer commit then +1 - I think the maintenance burden is light and if PHPStan stops supporting the option it'll tell us with an easy error to fix. Also happy to merge https://github.com/alexpott/d8githooks/pull/34/commits/6c03a0ceae34850a9... once this lands.
- πΊπΈUnited States nicxvan
Do you mean the print statements?
I had thought it would be helpful to clarify that memory limit is set since i assume most core committers use your precommit hooks and might not see the issue.
I'm happy to remove it too, just clarifying.
- π¬π§United Kingdom alexpott πͺπΊπ
Yep the print statements - I'm not sure they add anything.
- πΊπΈUnited States xjm
Thanks @alexpott! (@alexpott is the subsystem maintainer for this code.)
- π¬π§United Kingdom alexpott πͺπΊπ
looks good to me... will merge once this rtbc.
- πΊπΈUnited States xjm
I had thought it would be helpful to clarify that memory limit is set since i assume most core committers use your precommit hooks and might not see the issue.
We are a small group and whoever commits the followup to the git hooks will probably just tell the team. :)
I'll try to manually test this together with the PR later.