Save_edit in GIN admin theme in Drupal CMS (11) hardly accessible

Created on 7 June 2025, 1 day ago

Problem/Motivation

In the Gin admin theme of the current Drupal CMS edition the save_edit button is hidden inside a menu... see screenshot.
How can I get it out of there?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡¦πŸ‡ΉAustria maxilein

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @maxilein
  • πŸ‡¦πŸ‡ΉAustria maxilein
  • πŸ‡¦πŸ‡ΉAustria maxilein

    If I change save_edit.module line 57:

         if ($config->get('gin_primary')) {
            $form['actions']['save_edit']['#gin_action_item'] = TRUE;
          }
    

    to

          /*if ($config->get('gin_primary')) {*/
            $form['actions']['save_edit']['#gin_action_item'] = TRUE;
          /*}*/
    

    it works and is visible alongside the save button.

  • πŸ‡¦πŸ‡ΉAustria maxilein

    Whatever this line does
    if ($config->get('gin_primary')) {: Maybe the problem is that I use gin for admin theme (not main theme) and to edit content?

  • πŸ‡ΊπŸ‡ΈUnited States caesius

    Hi, please review this related issue: πŸ’¬ The "Save & Edit" button is hidden behind a "More actions" dropdown button in the Gin Admin theme Needs work

    This code was added because the button was hidden in the Gin theme. Now you're saying that with this code the button gets hidden?

    Please track down what specific version of the Gin theme this code worked on, and when it broke. Or see if it breaks in Drupal CMS but is fine in vanilla Drupal.

    If it breaks from a minor or patch update of the Gin admin theme, then I'd be fine removing all the Gin-related code from the module. However, if it only breaks on a major version update of the Gin theme, then I'd only be comfortable removing the code on a 2.0 release of this module in order to avoid breaking sites that haven't upgraded Gin yet.

    Either way I think moving forward I will not be accepting theme-specific accommodations for this module and would suggest custom code or a new submodule to deal with any issues a specific theme presents for the Save & Edit button (aside from Claro).

  • πŸ‡ΊπŸ‡ΈUnited States caesius
  • πŸ‡¦πŸ‡ΉAustria maxilein

    Sorry I was in the wrong. I used Version: 8.x-1.8 not the current dev version of save_ edit

Production build 0.71.5 2024