Package Manager should use a copy of Composer that is local to the current project, if available

Reviewable, but not ready quite yet since tests are needed.

I can't easily write a test for this, because although composer/composer is a dev dependency of core, vendor/bin/composer doesn't exist because it's cleaned up by the vendor hardening plugin, which has no way to prevent a package from being cleaned up. This also means that end users can't take advantage of this improvement if they have the vendor hardening plugin at all.

Not sure how to proceed. Should I change our build tests to confirm that this works? Should we file a blocking issue to allow the vendor hardening plugin to skip certain packages if configured to do so?

An update here -- if we can get ✨ Add a directory to the PATH Active in, this becomes much more viable, and would immediately improve things for Drupal CMS users -- if Composer installed and vendor/composer/composer/bin/composer exists, Package Manager would point to that.

The vendor hardening plugin would still be an obstacle for some sites -- although Drupal CMS does not currently use it -- but my idea there is to change it to not delete Composer's binaries outright, but rather just chmod them to 655 so that they cannot be executed directly. Then Composer simply becomes another PHP script run by the PHP interpreter, rather than something that can be invoked as its own process. All that would need to happen in a separate issue, though.

Postponing on the related issue.

Blocker landed!

Figured out how to write a unit test (a rare case where reflection is the way to go). This is reviewable!

Reviewed this with @phenaproxima and everything makes sense. Test coverage looks good.

One comment on the MR.

Easy enough. Since this was such a simple change with no logic implications, tentatively restoring Tim's prior RTBC.

Noticed one more thing - the static variable was unnecessary, @phenaproxima moved it to a normal property. We could maybe have done a separate method for testing instead but it's 50/50 so not worth further changes.

Committed/pushed to 11.x and cherry-picked to 11.2.x, thanks!

catch → closed merge request !12302

Automatically closed - issue fixed for 2 weeks with no activity.