- Issue created by @daniel_j
- First commit to issue fork.
- ๐ง๐ชBelgium dieterholvoet Brussels
Thanks for your contribution! I left some feedback in the MR, please commit any future changes there.
- First commit to issue fork.
- ๐ง๐ชBelgium dieterholvoet Brussels
Why did you revert the change?
str_starts_with
is still there. - ๐ฎ๐ณIndia harshitthakore Pune
I thought instead direct making changes, it's better to create patch file. So reverted it. Now, I have pushed that change also. Please review.
- ๐บ๐ธUnited States daniel_j
Just a note:
symfony/polyfill-php83
is pulled in by Drupal core, and it providesstr_starts_with()
if the PHP version is less than 8.3. - ๐ง๐ชBelgium dieterholvoet Brussels
I checked and you're right,
symfony/polyfill-php80
including thestr_starts_with
function was added in Drupal 9.0.0 โ . That would mean we need to drop support for Drupal 8, but I'm okay with that. Feel free to add backstr_starts_with
and drop support for D8 if you like.