- Issue created by @daniel_j
- First commit to issue fork.
- 🇧🇪Belgium dieterholvoet Brussels
Thanks for your contribution! I left some feedback in the MR, please commit any future changes there.
- First commit to issue fork.
- 🇧🇪Belgium dieterholvoet Brussels
Why did you revert the change?
str_starts_withis still there. - 🇮🇳India harshitthakore Pune
I thought instead direct making changes, it's better to create patch file. So reverted it. Now, I have pushed that change also. Please review.
- 🇺🇸United States daniel_j
Just a note:
symfony/polyfill-php83is pulled in by Drupal core, and it providesstr_starts_with()if the PHP version is less than 8.3. - 🇧🇪Belgium dieterholvoet Brussels
I checked and you're right,
symfony/polyfill-php80including thestr_starts_withfunction was added in Drupal 9.0.0 → . That would mean we need to drop support for Drupal 8, but I'm okay with that. Feel free to add backstr_starts_withand drop support for D8 if you like. - 🇺🇸United States daniel_j
I do not have push access to this issue, so I am attaching a patch file which ONLY contains the switch from
strncmp()tostr_starts_with()and drops D8 support. This patch should be applied against the issue fork/branch, not the 1.x branch. - 🇺🇸United States daniel_j
For those patching via composer, here is the full patch for this issue.
- 🇺🇸United States brenk28
Minor update to prev patch to fix number of args in str_starts_with.
- Status changed to Fixed
27 days ago 1:17pm 8 October 2025