- Issue created by @tgoeg
- 🇮🇹Italy bigbabert Milano, Italy
Hi @tgoeg,
thanks to raise the issue i'll fix in the weekend maybe i miss to clear the API input when user change the checkbox, it will be quick fix.
Best regards
- Merge request !5Fix DeepL free tier API not usable after unchecking DeepL pro checkbox → (Merged) created by tgoeg
- 🇦🇹Austria tgoeg
I think this is fixed.
I renamed the variable, as it would not be clear thatauto_translation_api_deepl_mode: true
would mean that _pro_ mode is enabled/true (but rather DeepL mode is enabled).
Therefore added an update hook as well for renaming the variable and converting 0 values for existing setups.
The default value also has a type cast to bool now as well, so we should always end up with a correct value in the DB.
Switched the detection from === 0 to === false, then.I tested it with my functioning setup (
false
; variable got renamed uponupdb
step).
Also tested it with a malfunctioning setup (0
; variable got renamed and cast tofalse
uponupdb
step)I think this should be OK, but please review. I am no real dev, just a sysadmin fixing stuff on the go :-)
- 🇮🇹Italy bigbabert Milano, Italy
Well done! i'll review/merge this weekend and pack new release togheter with the other
-
bigbabert →
committed ffc4d1d3 on 1.0.x authored by
tgoeg →
Issue #3526941 by tgoeg: DeepL free API: Error: Wrong endpoint. Use...
-
bigbabert →
committed ffc4d1d3 on 1.0.x authored by
tgoeg →