Use get_error_handler() in php 8.5

Added inline comments

Thanks for the review. I initially thought about addressing the missing return and the type hints but figured it was out of scope, since arguably we don't necessarily need to change the existing set_error_handler calls in the first place. The reference would make sense to address though. If we are going to refactor the anonymous function it would probably make sense to make it a static method on the Error class, since we're repeating it 4 times.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased and deprecated \Drupal\Core\Utility\Error::currentErrorHandler. Let's leave fixing up set_error_handler calls to another issue so we can consolidate similar callbacks and refine them there. We may need to fix _drupal_error_handler_real to return an int as per the expected method signature.

In fact let's use #3000229: Move error handlers to an Error class → to fix the set_error_handler calls

Do we need to do a dependency evaluation since this adds the polyfill.

Or is it different since this is symfony?

Just to make sure I understand this only replaced the instances where the error handler is swapped only to find the current handler.

I still have to pull down and confirm it's complete.

Do we need to do a dependency evaluation since this adds the polyfill.

Or is it different since this is a symfony library?

I think most symfony libraries would still need one, but not polyfills for php versions. We didn't for polyfill-php84 in 📌 Compatibility with Symfony 7.3 Active nor for polyfill-php83 in 📌 [11.x] [PP-1] Add PHP 8.3 requirement to Drupal 11.0.x Postponed .

Just to make sure I understand this only replaced the instances where the error handler is swapped only to find the current handler.

I replaced all calls to set_error_handler that used the result, to use get_error_handler instead. In some cases the callback passed to set_error_handler only existed so we could get the result. In other cases we were setting the error handler to something else, so we now get and set the handler in separate operations.

Thank you, I asked for confirmation in slack on the dependency.

Other than that I grepped for " = set_error_handler" and confirmed that all items were addressed.

I also confirmed that all instances of currentErrorHandler were replaced and the deprecation looks right.

Once the dependency question is resolved I think this is ready!

@catch confirmed on slack that polyfills can just be added and removed as needed.

larowlan → credited catch → .

Credits

We'll need a new hash in the composer.lock after 🐛 phpstan dev constraints make it difficult for modules to support 11.2 and below Active - fine to self RTBC after that

Rebased and regenerated the lock file

larowlan → closed merge request !12233

Committed to 11.x and published the change record

d.o ate Lee's credit. Fixing.