- Issue created by @penyaskito
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
wim leers β credited larowlan β .
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
I think this is good enough for unblocking other issues.
Created a bunch of follow-ups. - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
97% ready now! Some clarifications needed. Some bits. And a few simple bits of test coverage ππ€
Thanks, this looks like a solid start!
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
@penyaskito addressed all my feedback from yesterday. Looks great!
Just one last request for a
@todo <follow-up URL>
, but other than that, this is good to go, and a very nice first step! πSo: RTBC'ing, to allow @penyaskito to self-merge as soon as that last bit is done!
π’
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Oh and FYI, the docs I requested aren't in this MR, but in π Initial documentation draft Active , which I've also reviewed and is almost ready to land too π
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Needs rebase now that the docs MR is in π
Plus #11, of course.
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
Created π Add FilteredPluginExistsConstraint constraint for validating Segment config entity Active , back to RTBC
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Thanks for π Add FilteredPluginExistsConstraint constraint for validating Segment config entity Active ! That will actually be valuable in core too!
-
wim leers β
committed 72cb28ab on 0.x authored by
penyaskito β
Issue #3525601 by penyaskito, wim leers, larowlan: Personalization...
-
wim leers β
committed 72cb28ab on 0.x authored by
penyaskito β