- Issue created by @afi13
- Merge request !11Issue #3525298: Git rid of 'Hook Event Dispatcher' module dependency → (Open) created by afi13
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Thanks for the patch.
Please make coding standards fixes.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Why do the legacy hooks return values? The documentation for these hooks does not say that anything should be returned. If so, they should have the
void
return type declared. - 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Please rebase and remove the legacy hooks. This branch now has
core_version_constraint: ^10.4 || ^11.1
. -
liam morland →
committed aa4e8f78 on 2.2.x
Issue #3525298: Correct core_version_requirement
-
liam morland →
committed aa4e8f78 on 2.2.x
Without legacy hooks it won't work for Drupal from 10.1 to 11.0. So it cannot be supported in ^10.4 because this feature is landed in 11.1.
If we want to get rid of legacy hooks, then we need to use core_version_requirement: ^11.1 and remove 10.4 from core requirements.- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
OK, it will need to keep the legacy hooks. Thanks