- Issue created by @Liam Morland
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
What is the reason for using dependency injection and non-static methods for this? This way it will have to persist an instance of
DeleteUsersBatch
in the batch process. I don't think that is an improvement. - 🇮🇳India syam kumar
I agree with your point, and I would like to add a few observations:
1. Single Job Execution Issue:
In the current implementation, all users deletion activities are being executed within a single batch job operation. This design does not differ significantly from a traditional, monolithic deletion process. The primary advantage of batch jobs is to efficiently manage resources by breaking operations into smaller, manageable chunks.2. Dynamic Service Loading:
The required Drupal services are currently being loaded dynamically, which is typically more suited for procedural code (e.g., within `.module` files). However, Drupal best practices recommend using Dependency Injection (DI), especially in object-oriented components such as services, controllers, and plugins. Additionally using DI, makes it significantly easier to write unit tests. -
liam morland →
committed 7c0f1490 on 8.x-1.x
Issue #3524951: Allow use by users with permission `administer users`
-
liam morland →
committed 7c0f1490 on 8.x-1.x
-
liam morland →
committed 7a95094b on 8.x-1.x
Issue #3524951: Replace user_load_by_mail() with ::loadByProperties()...
-
liam morland →
committed 7a95094b on 8.x-1.x
-
liam morland →
committed 48245e06 on 8.x-1.x
Issue #3524951: Add link to People menu
-
liam morland →
committed 48245e06 on 8.x-1.x
-
liam morland →
committed 234707bd on 8.x-1.x
Issue #3524951: Refer to classes with ::class
-
liam morland →
committed 234707bd on 8.x-1.x
-
liam morland →
committed df2c4870 on 8.x-1.x
Issue #3524951: Call trim() on email addresses, including removing...
-
liam morland →
committed df2c4870 on 8.x-1.x
-
liam morland →
committed 2b1e796f on 8.x-1.x
Issue #3524951: Log when batch is finished
-
liam morland →
committed 2b1e796f on 8.x-1.x
-
liam morland →
committed aa8d787a on 8.x-1.x
Issue #3524951: Use str_contains() instead of strpos()
-
liam morland →
committed aa8d787a on 8.x-1.x
-
liam morland →
committed 24467242 on 8.x-1.x
Issue #3524951: Update user interface strings ::validateForm() is...
-
liam morland →
committed 24467242 on 8.x-1.x
-
liam morland →
committed da0e58fc on 8.x-1.x
Issue #3524951: Add `configure` property to info file
-
liam morland →
committed da0e58fc on 8.x-1.x
-
liam morland →
committed 0de661bc on 8.x-1.x
Issue #3524951: Create README file
-
liam morland →
committed 0de661bc on 8.x-1.x
-
liam morland →
committed d3f1506b on 8.x-1.x
Issue #3524951: Make DeleteUsersBatch::deleteUsersCallback() be static
-
liam morland →
committed d3f1506b on 8.x-1.x
-
liam morland →
committed b8631de8 on 8.x-1.x
Issue #3524951: Create .gitlab-ci.yml from template
-
liam morland →
committed b8631de8 on 8.x-1.x
-
liam morland →
committed 45f6d737 on 8.x-1.x
Issue #3524951: Update core_version_requirement
-
liam morland →
committed 45f6d737 on 8.x-1.x
-
liam morland →
committed 33866dce on 8.x-1.x
Issue #3524951: Make coding standards fixes
-
liam morland →
committed 33866dce on 8.x-1.x
-
liam morland →
committed c352795e on 8.x-1.x
Issue #3524951: Make automated coding standards fixes
-
liam morland →
committed c352795e on 8.x-1.x
-
liam morland →
committed 32f9bfd7 on 8.x-1.x
Issue #3524951: Delete empty delete_users_csv.module
-
liam morland →
committed 32f9bfd7 on 8.x-1.x
-
liam morland →
committed a271ec62 on 8.x-1.x
Issue #3524951: Remove LICENSE.txt The license will be added by the...
-
liam morland →
committed a271ec62 on 8.x-1.x
-
liam morland →
committed 558d5d02 on 8.x-1.x
Issue #3524951: Remove execute bits from files
-
liam morland →
committed 558d5d02 on 8.x-1.x