Update for Drupal 10/11

Created on 16 May 2025, 6 days ago

Update for Drupal 10/11.

๐Ÿ“Œ Task
Status

Active

Version

1.0

Component

Code

Created by

๐Ÿ‡จ๐Ÿ‡ฆCanada Liam Morland Ontario, CA ๐Ÿ‡จ๐Ÿ‡ฆ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Liam Morland
  • Pipeline finished with Success
    6 days ago
    Total: 462s
    #499043
  • Pipeline finished with Success
    6 days ago
    Total: 265s
    #499083
  • Pipeline finished with Success
    6 days ago
    Total: 138s
    #499108
  • Pipeline finished with Success
    6 days ago
    Total: 380s
    #499118
  • Pipeline finished with Success
    6 days ago
    Total: 137s
    #499172
  • ๐Ÿ‡จ๐Ÿ‡ฆCanada Liam Morland Ontario, CA ๐Ÿ‡จ๐Ÿ‡ฆ
  • Pipeline finished with Success
    6 days ago
    Total: 140s
    #499176
  • Pipeline finished with Success
    6 days ago
    Total: 282s
    #499182
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia syam kumar

    syam kumar โ†’ made their first commit to this issueโ€™s fork.

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada Liam Morland Ontario, CA ๐Ÿ‡จ๐Ÿ‡ฆ

    What is the reason for using dependency injection and non-static methods for this? This way it will have to persist an instance of DeleteUsersBatch in the batch process. I don't think that is an improvement.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia syam kumar

    I agree with your point, and I would like to add a few observations:

    1. Single Job Execution Issue:
    In the current implementation, all users deletion activities are being executed within a single batch job operation. This design does not differ significantly from a traditional, monolithic deletion process. The primary advantage of batch jobs is to efficiently manage resources by breaking operations into smaller, manageable chunks.

    2. Dynamic Service Loading:
    The required Drupal services are currently being loaded dynamically, which is typically more suited for procedural code (e.g., within `.module` files). However, Drupal best practices recommend using Dependency Injection (DI), especially in object-oriented components such as services, controllers, and plugins. Additionally using DI, makes it significantly easier to write unit tests.

Production build 0.71.5 2024