Contrib.social

Add : `void` return type to WebformSubmissionDevelGenerate::generateSubmissions()

Open on Drupal.org →
Created on 16 May 2025, about 2 months ago

Problem/Motivation

When using webform 6.3.x with devel_generate, generateSubmissions() lacks a : void return type

Steps to reproduce

  1. Enable webform and devel_generate.
  2. Generate some test submissions

Proposed resolution

Change signature to protected function generateSubmissions(array $values): void

🐛 Bug report
Status

Active

Version

6.3

Component

Code

Created by

🇦🇺Australia yovince Melbourne

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @yovince
  • Merge request !631Add void return type to WebformSubmissionDevelGenerate::generateSubmissions() → (Open) created by yovince
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1183s
    #498645
  • Comment about 2 months ago →
    🇦🇺Australia yovince Melbourne

    Also upload a patch compatible with 6.3.0-beta2.

  • Pipeline finished with Failed
    about 2 months ago
    Total: 661s
    #498695
  • Pipeline finished with Failed
    about 2 months ago
    Total: 738s
    #498701
  • Comment about 2 months ago →
    🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

    Thanks for the patch.

    Why is this change required? Please update the issue summary.

    Tests are not passing.

  • Pipeline finished with Canceled
    about 1 month ago
    Total: 618s
    #506517
  • Pipeline finished with Success
    about 1 month ago
    Total: 870s
    #506523
  • Pipeline finished with Success
    about 1 month ago
    Total: 1044s
    #506524
  • Pipeline finished with Success
    about 1 month ago
    Total: 422s
    #506542
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024