Add : `void` return type to WebformSubmissionDevelGenerate::generateSubmissions()

Created on 16 May 2025, 5 months ago

Problem/Motivation

When using webform 6.3.x with devel_generate, generateSubmissions() lacks a : void return type

Steps to reproduce

  1. Enable webform and devel_generate.
  2. Generate some test submissions

Proposed resolution

Change signature to protected function generateSubmissions(array $values): void

πŸ› Bug report
Status

Active

Version

6.3

Component

Code

Created by

πŸ‡¦πŸ‡ΊAustralia yovince Melbourne

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @yovince
  • Pipeline finished with Failed
    5 months ago
    Total: 1183s
    #498645
  • πŸ‡¦πŸ‡ΊAustralia yovince Melbourne

    Also upload a patch compatible with 6.3.0-beta2.

  • Pipeline finished with Failed
    5 months ago
    Total: 661s
    #498695
  • Pipeline finished with Failed
    5 months ago
    Total: 738s
    #498701
  • πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

    Thanks for the patch.

    Why is this change required? Please update the issue summary.

    Tests are not passing.

  • Pipeline finished with Canceled
    5 months ago
    Total: 618s
    #506517
  • Pipeline finished with Success
    5 months ago
    Total: 870s
    #506523
  • Pipeline finished with Success
    5 months ago
    Total: 1044s
    #506524
  • Pipeline finished with Success
    5 months ago
    Total: 422s
    #506542
  • Status changed to RTBC about 2 months ago
  • πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

    This MR is an API cleanup, which I think is okay.

  • πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

    I see it is a protected method and its return value is not used. In theory someone could sub-class this and use the return value. This could have a change record. I have updated the issue title to make it more clear what is happening, so perhaps the release notes are sufficient, rather than using a change record.

  • Pipeline finished with Success
    about 2 months ago
    Total: 620s
    #583393
  • Pipeline finished with Skipped
    about 2 months ago
    #583516
  • πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY
  • Pipeline finished with Failed
    18 days ago
    Total: 1113s
    #609327
  • Pipeline finished with Success
    18 days ago
    Total: 962s
    #609336
  • Pipeline finished with Failed
    18 days ago
    Total: 823s
    #609352
  • Pipeline finished with Failed
    18 days ago
    Total: 9848s
    #609358
  • Pipeline finished with Success
    18 days ago
    Total: 1397s
    #609628
  • Pipeline finished with Canceled
    18 days ago
    Total: 75s
    #609892
  • Pipeline finished with Success
    18 days ago
    Total: 1535s
    #609894
Production build 0.71.5 2024