Unlike for the block component source plugin (see
📌
`BlockComponent::validateComponentInput()` allows garbage to pile up
Active
), no garbage values are AFAICT allowed for the sdc and js component sources.
This is thanks to GeneratedFieldExplicitInputUxComponentSourceBase::validateComponentInput() calling
$this->componentValidator->validateProps($resolvedInputValues, $this->getSdcPlugin());
which would complain about unused props.
… or so I think 😅
Add test coverage to prove that the SDC + JS component sources are unaffected.
None.
Active
0.0
Component sources
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Could you please give an example for 'garbage value'?
An SDC with the following in its *.component.yml:
props:
type: object
required:
- heading
properties:
heading:
type: string
title: Heading
examples:
- blabla
… yet the explicit input it receives is not
heading: "something"
but
heading: "something"
foo: :"bar"
IOW: some key-value pairs that are not expected by the SDC!