[pp-1] Move or delete olivero_drupal_alter_alter

Created on 13 May 2025, 21 days ago

Problem/Motivation

Postponed on πŸ“Œ Convert common_test hooks and delete .module Active
olivero_drupal_alter_alter was created at a time before drupal had test themes so this was shoehorned into common_test. There are now dedicated test themes and dedicated test for theme form alters so we can delete this function and related tests.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Active

Version

11.0 πŸ”₯

Component

theme system

Created by

πŸ‡ΊπŸ‡ΈUnited States nicxvan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @nicxvan
  • πŸ‡¨πŸ‡­Switzerland berdir Switzerland

    For more context, this was originally added by #591794: Allow themes to alter forms and page β†’ in 2009.

    This might sound confusing as olivero isn't that old. But it was just renamed, I guess a few times. In 2009 it was originally added as garland_drupal_alter_alter.

    Originally, this was a test to make sure that themes can implement every alter hook, with a made up hook name only used in that test. This was changed, theme alters only work for specific, explicitly called alter hooks, and the test was extend in #2228093: Modernize theme initialization β†’ and lost its original purpose already kind of then.

    IMHO, we have test coverage of test themes implementing actual alter hooks and we could just drop that hook and that part of the test, but I'm also fine wit just moving the hook to test_theme or something.

Production build 0.71.5 2024